NIAD-3216: When DiagnosticReport doesn't contain a Specimen reference, we are sending a value of DUMMY #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonopono123
reviewed
Sep 22, 2025
| return nonFilingObservations; | ||
| } | ||
|
|
||
| private Specimen generateDummySpecimen(DiagnosticReport diagnosticReport) { |
Contributor
There was a problem hiding this comment.
If we're not using "DUMMY" anymore, should this be renamed as well?
Contributor
There was a problem hiding this comment.
thanks @Jonopono123, that's a good suggestion, I will rename it
MartinWheelerMT
approved these changes
Sep 24, 2025
Collaborator
MartinWheelerMT
left a comment
MartinWheelerMT
left a comment
There was a problem hiding this comment.
I've approved this as it solves the scope of the ticket, however there a still a lot of places in codebase referring to the term DUMMY which I'd like to see removed also.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is to implement the bug-fix raised in the ticket NIAD-3216.
When testing NIAD-3213, it was observed that SystemOne displays the "Specimen ID": of "DUMMY".
Why
This looks inappropriate within the patient's record. The logic is fine and so it will be changed to "Not present" instead.
Type of change
Checklist: